Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: footer link colors to use customizable CSS variables #2658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-zoos-vanish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@utrecht/page-footer-css": minor
---

Refactor page-footer color definitions to use CSS variables with fallbacks
14 changes: 7 additions & 7 deletions components/page-footer/src/_mixin.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
}

@mixin utrecht-page-footer {
--utrecht-document-color: currentColor;
--utrecht-heading-color: currentColor;
--utrecht-link-color: currentColor;
--utrecht-link-focus-color: currentColor;
--utrecht-link-hover-color: currentColor;
--utrecht-link-active-color: currentColor;
--utrecht-link-visited-color: currentColor;
--utrecht-document-color: var(--utrecht-footer-document-color, currentColor);
--utrecht-heading-color: var(--utrecht-footer-heading-color, currentColor);
--utrecht-link-color: var(--utrecht-footer-link-color, currentColor);
--utrecht-link-focus-color: var(--utrecht-footer-link-focus-color, currentColor);
--utrecht-link-hover-color: var(--utrecht-footer-link-hover-color, currentColor);
--utrecht-link-active-color: var(--utrecht-footer-link-active-color, currentColor);
--utrecht-link-visited-color: var(--utrecht-footer-link-visited-color, currentColor);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marwaxhello Ik denk dat het misschien ook werkt (en dan simpeler is) om de oude code te verplaatsen naar utrecht-page-footer__content

Het gedrag zal een paar weken geleden kapot zijn gegaan door de introductie van utrecht-page-footer__content.

Wat dat betreft zou dit een patch zijn en niet minor


background-color: var(--utrecht-page-footer-background-color);
background-image: var(--utrecht-page-footer-background-image);
Expand Down
Loading