Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dream-html package #1150

Merged
merged 5 commits into from
Nov 12, 2023
Merged

Add dream-html package #1150

merged 5 commits into from
Nov 12, 2023

Conversation

neshtea
Copy link
Contributor

@neshtea neshtea commented Nov 12, 2023

This pull-request includes a derivation for yawaramin/dream-html. Since aantron/dream is already included in this overlay, I've found it useful to include this as well.

Copy link
Collaborator

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the release tag for 1.1.0 or does the rev you added have more fixes?

@neshtea
Copy link
Contributor Author

neshtea commented Nov 12, 2023

I thought that was the commit sha of the commit that introduced 1.1.0. What am I missing/what should I change it to?

@anmonteiro
Copy link
Collaborator

I thought that was the commit sha of the commit that introduced 1.1.0. What am I missing/what should I change it to?

rev = “1.1.0”

@neshtea
Copy link
Contributor Author

neshtea commented Nov 12, 2023

rev = “1.1.0”

Thanks for pointing that out, completely slipped my mind as a possibility.

@anmonteiro anmonteiro merged commit 48dbfaf into nix-ocaml:master Nov 12, 2023
15 checks passed
@anmonteiro
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants