Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: skip check completely when checkConfig=false #6293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ian-h-chamberlain
Copy link

Fixes #5753

Description

Also add an allowUnknownSettings option to enable checking everything except for unknown settings.

Checklist

  • Change is backwards compatible.

    NOTE: the caveat here is that users who previously had checkConfig = false will now have less checks performed than they did previously, but frankly I'm not sure it was even checking anything useful, since "unknown settings" seem to be emitted much later vs other kind of errors. A config like this only errors on keep-outputs and doesn't complain about the unknown setting at all:

     keep-outputs = 123
     some-other-setting = true
  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.
    NOTE: just testing the new tests I added and other nix.conf related tests

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

Also add an `allowUnknownSettings` option to enable checking everything
except for unknown settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: nix.checkConfig = false still fails on unknown settings
1 participant