nix: skip check completely when checkConfig=false #6293
+87
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5753
Description
Also add an
allowUnknownSettings
option to enable checking everything except for unknown settings.Checklist
Change is backwards compatible.
NOTE: the caveat here is that users who previously had
checkConfig = false
will now have less checks performed than they did previously, but frankly I'm not sure it was even checking anything useful, since "unknown settings" seem to be emitted much later vs other kind of errors. A config like this only errors onkeep-outputs
and doesn't complain about the unknown setting at all:Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.NOTE: just testing the new tests I added and other
nix.conf
related testsTest cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC