Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: expose session variables package #6291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ian-h-chamberlain
Copy link

@ian-h-chamberlain ian-h-chamberlain commented Jan 8, 2025

Description

Closes #5602

Expose the builtin fish-translated hm-session-vars.fish as a package, and include it by default when programs.fish.enable = true.

This allows fish users to source the hm-session-vars.fish if they are not using the generated config.fish (which now sources the same file).

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.
    (ran the relevant tests, not the whole world though)

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@

@ian-h-chamberlain ian-h-chamberlain marked this pull request as draft January 8, 2025 21:56
@github-actions github-actions bot added the shell label Jan 8, 2025
This allows fish users to source the `hm-session-vars.fish` if they are
not using the generated `config.fish` (which now sources the same file).
@ian-h-chamberlain ian-h-chamberlain force-pushed the feature/fish-session-vars-pkg branch from b06023b to e48030e Compare January 8, 2025 22:40
@github-actions github-actions bot removed the shell label Jan 8, 2025
@ian-h-chamberlain ian-h-chamberlain marked this pull request as ready for review January 8, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to expose fish translatedSessionVariables (hm-session-vars.fish)?
1 participant