Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: init module #6288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

folliehiyuki
Copy link
Contributor

Description

This PR adds a new module programs.helm to install Helm package and manage Helm plugins.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@teto
Copy link
Collaborator

teto commented Jan 8, 2025

before starting a review do you need this even when wrapHelm exists ?

@folliehiyuki
Copy link
Contributor Author

folliehiyuki commented Jan 8, 2025

I didn't know about wrapHelm. The wrapper approach overrides HELM_PLUGINS variable, pointing it to the Nix store, so it doesn't allow users to install a random Helm plugin with an one-off helm plugin install command.

With that said, I only use a few Helm plugins and they are all available in Nixpkgs. If no one desires the interactive CLI use case, I'll close this PR.

Thanks for the info btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants