Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eww: make configDir optional #6282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aster-void
Copy link

@aster-void aster-void commented Jan 7, 2025

Description

eww's configDir does not need to be required, as some people (like me) prefer managing their dotfiles themselves.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.
    -> not yet

  • Test cases updated/added. See example.
    -> marking as complete as I don't think this is necessary on this PR.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
      -> marking as complete as it doesn't add a new module.

Maintainer CC

@mainrs

reason: some people (such as me) like to manage config directories themselves, and it should not be a requirement but rather an optional feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant