Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpaperd: add systemd service; move to services/ from programs/ #6278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

3ulalia
Copy link

@3ulalia 3ulalia commented Jan 6, 2025

Description

Re: #4538, wpaperd needs something to run it after being enabled. This commit adds a systemd service to run it, and accordingly moves it to services.wpaperd.

In addition, the existing tests have been migrated to services, and an entry in the newslist has been created alerting users to this change.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@Avimitin

@3ulalia
Copy link
Author

3ulalia commented Jan 6, 2025

CC @thiagokokada

modules/services/wpaperd.nix Show resolved Hide resolved
modules/services/wpaperd.nix Show resolved Hide resolved
modules/services/wpaperd.nix Show resolved Hide resolved
Re: nix-community#4538, wpaperd needs something to run it after being enabled. This commit adds a systemd service to run it, and accordingly moves it to services.wpaperd.

In addition, the existing tests have been migrated to services, and an entry in the newslist has been created alerting users to this change.
@teto
Copy link
Collaborator

teto commented Jan 8, 2025

I dont have a strong opinion on this but it might make sense to have programs AND service separate in case you want to generate a config without the service. That would be for wpaperd maintainer to decide.

@3ulalia
Copy link
Author

3ulalia commented Jan 8, 2025

I don't know if I agree with that but certainly I'd love to hear from @Avimitin. That doesn't really line up with the way that other programs have been implemented - home-manager is somewhat opinionated whether things should be programs or services.

@Avimitin
Copy link
Contributor

Avimitin commented Jan 8, 2025

In my previous use case, wpaperd is not usually used as a standalone program. So from my own perspective, for those users who want to use home manager to manage their wpaperd configuration, they might also want the systemd user service installed automatically. So I think having only one service module is ok.

Also, I want to quit the wpaperd maintainer since KDE is now my daily desktop environment. This has nothing to do with this PR, I just want to express that I might miss some new best practices for wpaperd. Please do what you think is right as you see fit.

@3ulalia
Copy link
Author

3ulalia commented Jan 10, 2025

Hello,

That's good to know, and I'd be happy to take up the mantle. I'll go ahead and add myself as a maintainer and remove you, if that works? Thanks for all the work you've done so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants