Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpdscribble: add module #6259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

msyds
Copy link

@msyds msyds commented Jan 2, 2025

Description

This PR adds the module services.mpdscribble based on the NixOS module of the same name.

Old feature request: #4963

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

@msyds msyds force-pushed the service-mpdscribble branch from bf84ed3 to 6948b7b Compare January 2, 2025 12:25
@teto
Copy link
Collaborator

teto commented Jan 8, 2025

Looks like a valid candidate for HM. If anyone else could try this out and report back, it would be nice.

@msyds msyds force-pushed the service-mpdscribble branch from e606f2d to 71be4c3 Compare January 9, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants