Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to expose fish translatedSessionVariables (hm-session-vars.fish)? #5602

Open
ian-h-chamberlain opened this issue Jul 3, 2024 · 2 comments · May be fixed by #6291
Open

Possible to expose fish translatedSessionVariables (hm-session-vars.fish)? #5602

ian-h-chamberlain opened this issue Jul 3, 2024 · 2 comments · May be fixed by #6291
Assignees
@rycee @sumnerevans @berbiche
Labels
feature request

Comments

@ian-h-chamberlain
Copy link

ian-h-chamberlain commented Jul 3, 2024 •
edited
Loading

Description

#4012 seems like a great improvement, but I can't seem to figure out any way to independently source the hm-session-vars.fish it generates. I am using xdg.configFile."fish/config.fish".enable = false so that I can keep using my own non-Nixified config.fish, but I'd still like to be able to source it to reflect any changes in home.nix.

Up until now, I have been using source ~/.nix-profile/etc/profile.d/nix.fish and didn't run into any problems, but when I tried to add sessionVariables of my own, I realized they weren't reflected there. ~/.nix-profile/etc/profile.d/hm-session-vars.sh does contain the settings I expect, but it seems pointless to do the translation myself when I know home-manager is already performing that translation at build time.

Would it make sense to simply link the hm-session-vars.fish into that same directory, or otherwise expose a variable that I could use to link the file somewhere I can source it? Thank you!

Edit: also, happy to try my hand at submitting a PR if someone can point me in the right direction and this seems like a change that would be accepted!
@stale Stale
Copy link

stale bot commented Jan 3, 2025

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

@stale stale bot added the status: stale label Jan 3, 2025
@ian-h-chamberlain
Copy link
Author

I have implemented a basic version of this for my own personal use, so I'll try to clean it up and open a PR to unstale this issue.

@stale stale bot removed the status: stale label Jan 7, 2025
@ian-h-chamberlain ian-h-chamberlain linked a pull request Jan 8, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rycee rycee

@sumnerevans sumnerevans

@berbiche berbiche

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fish: expose session variables package ian-h-chamberlain/home-manager
4 participants
@rycee @ian-h-chamberlain @sumnerevans @berbiche