Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to forbid viewing other's modification history. #208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Option to forbid viewing other's modification history. #208

wants to merge 2 commits into from

Conversation

cryptogun
Copy link
Contributor

For privacy concern.
Comment author can view their own comment modification history, but not other user's.
Moderators can view anyone's history.
Switch: ST_CUSTOMIZE_ALLOW_OTHERS_VIEWING_MODIFICATION_HISTORY

@cryptogun
Option to forbid viewing other's modification history.
f261d09 
Comment author can view their own comment modification history. Moderators can view anyone's history.
@coveralls
Copy link

coveralls commented Nov 4, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.009%) to 96.967% when pulling f261d09 on cryptogun:cry/feature/forbid_viewing_others_modi_history into b46207e on nitely:master.

@nitely
Copy link
Owner

nitely commented Nov 4, 2017 •
edited
Loading

For privacy concern.

How so? What about quotes? What about screenshots? What about wayback machine? What about Google's cache? What about...

@cryptogun
Copy link
Contributor Author

Well GitHub comment does so :)
e.g. You post your phone number, then thousands of spams came, then you edited your comment. No help if the history can be viewed by anyone.
Besides correcting typo, there are other use case why people change their comment.

@nitely
Copy link
Owner

nitely commented Nov 4, 2017

e.g. You post your phone number, then thousands of spams came, then you edited your comment. No help if the history can be viewed by anyone.

History can only be seen by registered users.

@nitely
Copy link
Owner

nitely commented Nov 4, 2017

Well GitHub comment does so :)

Github comments are not exactly the best thing ever (to put it nicely).

Besides correcting typo, there are other use case why people change their comment.

No reason to hide the history then?

@cryptogun
Copy link
Contributor Author

Many reasons a human to hide their history. Human lies and always lies. They need something to cover their trails. Discuz hides them, I'm familiar with that, people would feel more free. So why not leave it an option, let the forum owner do the choice.
By the way, if you need justise, tell a moderator, he can see anything.

nitely
nitely reviewed Nov 4, 2017
View reviewed changes
spirit/core/conf/defaults.py Outdated
@@ -100,3 +100,5 @@
os.path.dirname(
os.path.dirname(
os.path.dirname(__file__))))

ST_CUSTOMIZE_ALLOW_OTHERS_VIEWING_MODIFICATION_HISTORY = False
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be called ST_PRIVATE_COMMENT_HISTORY

spirit/comment/history/views.py Outdated
@@ -17,6 +19,12 @@ def detail(request, comment_id):
comment = get_object_or_404(Comment.objects.for_access(request.user),
pk=comment_id)

# not comment author and not moderator:
if request.user != comment.user and not request.user.st.is_moderator:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and ST_PRIVATE_COMMENT_HISTORY is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

@nitely
Copy link
Owner

nitely commented Nov 4, 2017 •
edited
Loading

Many reasons a human to hide their history. Human lies and always lies. They need something to cover their trails.

haha What kind of forum are you running? 👅 Anyway, I'll think about it. But please add tests.

Human lies and always lies. They need something to cover their trails. Discuz hides them, I'm familiar with that, people would feel more free.

I dunno. Other users can still quote, so I don't think they will feel more free than usual.

@cryptogun
Copy link
Contributor Author

I own none but I register one. It has 700k registered users, and 10k new comments daily. The fun point is reply with "pay me or your wife may see it some day" after quoting :)

@nitely nitely mentioned this pull request Nov 4, 2017
Closed
@coveralls
Copy link

coveralls commented Nov 5, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 96.978% when pulling 762fb32 on cryptogun:cry/feature/forbid_viewing_others_modi_history into b46207e on nitely:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitely nitely nitely left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cryptogun @coveralls @nitely