Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #252

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

wip #252

wants to merge 2 commits into from

Conversation

onmax
Copy link
Member

@onmax onmax commented Jan 21, 2025

TODOs

  • Setup Wallet with no storage and "playground" mode
  • Create dummy account with dummy data
  • Hijack requests to HubApi
  • Implement fake buy
  • Implement fake sell
  • Fix Identicons in list
  • Enable USDC/USDT
  • Fake Swaps
  • Implement visual clues
  • Implement iframe messages to change visual clues both ways
  • Implement fake Staking
  • Display swapped amount
  • Disable changing staking amount
  • Discuss about fallback modal and improve design
  • Undo changes in sidebar.
  • Undo changes in Buy Modal.

  • Got error while redirecting:
Error: Redirected when going from "/?demo=" to "/staking" via a navigation guard.
    at createRouterError (vue-router.esm.js:2056:15)
    at createNavigationRedirectedError (vue-router.esm.js:2015:10)
    at eval (vue-router.esm.js:2386:17)
    at eval (Demo.ts:138:1)
    at iterator (vue-router.esm.js:2372:7)
    at step (vue-router.esm.js:2097:9)
    at eval (vue-router.esm.js:2098:11)
    at eval (vue-router.esm.js:2394:11)
    at eval (router.ts:529:1)

@onmax onmax force-pushed the playground branch 3 times, most recently from e6a9a93 to 45bdb4a Compare January 21, 2025 15:01
@@ -53,7 +53,7 @@
"v-click-outside": "^3.0.1",
"vue": "^2.6.11",
"vue-i18n": "^8.15.5",
"vue-router": "^3.1.6",
"vue-router": "^3.5.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on the wallet playground. I want to add some routes, but since it's only for playground mode, I don't want to do it in router.ts, but rather dynamically.

I had to update vue-router to be able to add routes to specific children using addRoute. Maybe there is another way, but also it doesn't hurt to update now, as it is something less for the future :).

There are no breaking changes between 3.1 and 3.5: https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md#350-2021-01-25 except for a few TS issues, which you can find in this commit.

@sisou @danimoh do you agree with this decision?

@onmax onmax force-pushed the playground branch 3 times, most recently from ea24d5f to 734d254 Compare January 23, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant