Multisig: Connect request and SignMultisigTransaction request #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
force-pushed
the
multisig
branch
2 times, most recently
from
08af4d0 to
08748bb
Compare
sisou
force-pushed
the
multisig
branch
2 times, most recently
from
0482b2d to
da83212
Compare
sisou
force-pushed
the
multisig
branch
2 times, most recently
from
26cbddd to
58a01c6
Compare
from participants' public keys
Missing multisig-specific UI elements
Because CSP doesn't allow inline-scripts. This required getting the types for node-forge correct, too.
Requires passing the parameters in the request to ensure generation of the correct decryption key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: nimiq/hub#521
This PR adds two requests:
Connect
For this request, I am adding deterministic RSA key generation from the user's Key's
secret. The public RSA key is then shared with the connected app, to be able to encrypt data that only the Keyguard can decrypt again. Encryption and decryption uses thewindow.crypto.subtleAPIs.SignMultisigRequest
For this request, I am adding a WebAssembly file + JS loader, and the raw Rust code that produces it. This is needed as with the multisig scheme Nimiq is using, scalar multiplication is required, which we cannot do in Javascript. A minimal Rust crate does the trick, and is used as WASM when signing.