Skip to content

server: Do not echo the close message #74

server: Do not echo the close message

server: Do not echo the close message #74

GitHub Actions / Clippy Report succeeded Feb 21, 2024 in 0s

Clippy Report

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.76.0 (07dca489a 2024-02-04)
  • cargo 1.76.0 (c84b36747 2024-01-18)
  • clippy 0.1.76 (07dca48 2024-02-04)

Annotations

Check warning on line 113 in client/src/wasm_websocket.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> client/src/wasm_websocket.rs:113:24
    |
113 |         let ready_tx = Arc::new(RefCell::new(Some(ready_tx)));
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<RefCell<Option<Sender<()>>>>` is not `Send` and `Sync` as:
    = note: - the trait `Sync` is not implemented for `RefCell<Option<Sender<()>>>`
    = help: consider using an `Rc` instead. `Arc` does not provide benefits for non `Send` and `Sync` types
    = note: if you intend to use `Arc` with `Send` and `Sync` traits
    = note: wrap the inner type with a `Mutex` or implement `Send` and `Sync` for `RefCell<Option<Sender<()>>>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
    = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 225 in server/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

non-binding `let` on a future

warning: non-binding `let` on a future
   --> server/src/lib.rs:225:25
    |
225 |                         let _ = tx.close();
    |                         ^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
    = note: `#[warn(clippy::let_underscore_future)]` on by default

Check warning on line 113 in client/src/wasm_websocket.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> client/src/wasm_websocket.rs:113:24
    |
113 |         let ready_tx = Arc::new(RefCell::new(Some(ready_tx)));
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<RefCell<Option<Sender<()>>>>` is not `Send` and `Sync` as:
    = note: - the trait `Sync` is not implemented for `RefCell<Option<Sender<()>>>`
    = help: consider using an `Rc` instead. `Arc` does not provide benefits for non `Send` and `Sync` types
    = note: if you intend to use `Arc` with `Send` and `Sync` traits
    = note: wrap the inner type with a `Mutex` or implement `Send` and `Sync` for `RefCell<Option<Sender<()>>>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
    = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 225 in server/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

non-binding `let` on a future

warning: non-binding `let` on a future
   --> server/src/lib.rs:225:25
    |
225 |                         let _ = tx.close();
    |                         ^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
    = note: `#[warn(clippy::let_underscore_future)]` on by default

Check warning on line 113 in client/src/wasm_websocket.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> client/src/wasm_websocket.rs:113:24
    |
113 |         let ready_tx = Arc::new(RefCell::new(Some(ready_tx)));
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<RefCell<Option<Sender<()>>>>` is not `Send` and `Sync` as:
    = note: - the trait `Sync` is not implemented for `RefCell<Option<Sender<()>>>`
    = help: consider using an `Rc` instead. `Arc` does not provide benefits for non `Send` and `Sync` types
    = note: if you intend to use `Arc` with `Send` and `Sync` traits
    = note: wrap the inner type with a `Mutex` or implement `Send` and `Sync` for `RefCell<Option<Sender<()>>>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
    = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 225 in server/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

non-binding `let` on a future

warning: non-binding `let` on a future
   --> server/src/lib.rs:225:25
    |
225 |                         let _ = tx.close();
    |                         ^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
    = note: `#[warn(clippy::let_underscore_future)]` on by default