Return error message to client upon providing incorrect method parame… #119
Annotations
11 warnings
rustfmt
Unexpected input(s) 'profile', 'override', valid inputs are ['toolchain', 'targets', 'target', 'components']
|
test
Unexpected input(s) 'profile', 'override', valid inputs are ['toolchain', 'targets', 'target', 'components']
|
unnecessary closure used to substitute value for `Option::None`:
core/src/lib.rs#L346
warning: unnecessary closure used to substitute value for `Option::None`
--> core/src/lib.rs:346:33
|
346 | Value::Number(n) => n
| _________________________________^
347 | | .as_u64()
348 | | .map(SubscriptionId::Number)
349 | | .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
| |______________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
|
349 | .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
usage of an `Arc` that is not `Send` and `Sync`:
client/src/wasm_websocket.rs#L113
warning: usage of an `Arc` that is not `Send` and `Sync`
--> client/src/wasm_websocket.rs:113:24
|
113 | let ready_tx = Arc::new(RefCell::new(Some(ready_tx)));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `Arc<RefCell<Option<Sender<()>>>>` is not `Send` and `Sync` as `RefCell<Option<Sender<()>>>` is not `Sync`
= help: if the `Arc` will not used be across threads replace it with an `Rc`
= help: otherwise make `RefCell<Option<Sender<()>>>` `Send` and `Sync` or consider a wrapper type such as `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
= note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
|
unnecessary closure used to substitute value for `Option::None`:
core/src/lib.rs#L346
warning: unnecessary closure used to substitute value for `Option::None`
--> core/src/lib.rs:346:33
|
346 | Value::Number(n) => n
| _________________________________^
347 | | .as_u64()
348 | | .map(SubscriptionId::Number)
349 | | .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
| |______________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
|
349 | .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
unnecessary closure used to substitute value for `Option::None`:
core/src/lib.rs#L346
warning: unnecessary closure used to substitute value for `Option::None`
--> core/src/lib.rs:346:33
|
346 | Value::Number(n) => n
| _________________________________^
347 | | .as_u64()
348 | | .map(SubscriptionId::Number)
349 | | .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
| |______________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
|
349 | .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
clippy
Unexpected input(s) 'profile', 'override', valid inputs are ['toolchain', 'targets', 'target', 'components']
|
unnecessary closure used to substitute value for `Option::None`:
core/src/lib.rs#L346
warning: unnecessary closure used to substitute value for `Option::None`
--> core/src/lib.rs:346:33
|
346 | Value::Number(n) => n
| _________________________________^
347 | | .as_u64()
348 | | .map(SubscriptionId::Number)
349 | | .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
| |______________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
|
349 | .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
usage of an `Arc` that is not `Send` and `Sync`:
client/src/wasm_websocket.rs#L113
warning: usage of an `Arc` that is not `Send` and `Sync`
--> client/src/wasm_websocket.rs:113:24
|
113 | let ready_tx = Arc::new(RefCell::new(Some(ready_tx)));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `Arc<RefCell<Option<Sender<()>>>>` is not `Send` and `Sync` as `RefCell<Option<Sender<()>>>` is not `Sync`
= help: if the `Arc` will not used be across threads replace it with an `Rc`
= help: otherwise make `RefCell<Option<Sender<()>>>` `Send` and `Sync` or consider a wrapper type such as `Mutex`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
= note: `#[warn(clippy::arc_with_non_send_sync)]` on by default
|
unnecessary closure used to substitute value for `Option::None`:
core/src/lib.rs#L346
warning: unnecessary closure used to substitute value for `Option::None`
--> core/src/lib.rs:346:33
|
346 | Value::Number(n) => n
| _________________________________^
347 | | .as_u64()
348 | | .map(SubscriptionId::Number)
349 | | .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
| |______________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
|
349 | .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
unnecessary closure used to substitute value for `Option::None`:
core/src/lib.rs#L346
warning: unnecessary closure used to substitute value for `Option::None`
--> core/src/lib.rs:346:33
|
346 | Value::Number(n) => n
| _________________________________^
347 | | .as_u64()
348 | | .map(SubscriptionId::Number)
349 | | .ok_or_else(|| Error::InvalidSubscriptionId(Value::Number(n))),
| |______________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
|
349 | .ok_or(Error::InvalidSubscriptionId(Value::Number(n))),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|