Consensus: fix history sync while processing received BatchSetInfo
#3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
reviewed
Jan 9, 2025
Eligioo
force-pushed
the
stefan/history-sync-fix
branch
from
92b52c3 to
315d58a
Compare
jsdanielh
force-pushed
the
stefan/history-sync-fix
branch
from
315d58a to
7c82820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Determining the number of known transactions while processing received
BatchSetInfos, could result into crossing an epoch boundary. This would result into skipping the entireBatchSetInfofor the current epoch the node is in and prevent it from downloading new history chunks.Fixes #3206.
Pull request checklist
clippyandrustfmtwarnings.