Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC client create_validator uses the configuration as input #3226

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ii-cruz
Copy link
Member

@ii-cruz ii-cruz commented Jan 7, 2025

What's in this pull request?

The RPC client's operations for the validator were designed to be applied to the local validator. The create validator was the exception. This PR standardizes it.
To submit txs regarding other validators one can use the send raw transaction.

This fixes #3225.

Pull request checklist

  • All tests pass. The project builds and runs.
  • I have resolved any merge conflicts.
  • I have resolved all clippy and rustfmt warnings.

@ii-cruz ii-cruz added the enhancement New feature or request label Jan 7, 2025
@ii-cruz ii-cruz added this to the Next release milestone Jan 7, 2025
@ii-cruz ii-cruz self-assigned this Jan 7, 2025
Copy link
Member

@sisou sisou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! If this only changes the client implementation and not the RPC server interface then I'm OK with this.

@sisou sisou changed the title RPC create_validator uses the client configuration as input RPC client create_validator uses the configuration as input Jan 7, 2025
@jsdanielh jsdanielh force-pushed the iicruz/rpc-restrict-create-validator-tx branch from 4feeaeb to 7869b71 Compare January 10, 2025 19:03
@jsdanielh jsdanielh merged commit 7869b71 into albatross Jan 10, 2025
8 checks passed
@jsdanielh jsdanielh deleted the iicruz/rpc-restrict-create-validator-tx branch January 10, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC Client: take signing key from node config when creating a validator
4 participants