Skip to content

Commit

Permalink
Re-enable dartdevc_test(google#619)
Browse files Browse the repository at this point in the history
The build_packages have NNBD releases.
  • Loading branch information
niku committed Oct 16, 2021
1 parent eb643e6 commit 7b4b8cc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
6 changes: 3 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ dependencies:
dev_dependencies:
path: ^1.8.0
test: ^1.16.0
#DDC_TEST: build_runner: ^1.3.1
#DDC_TEST: build_test: ^0.10.6
#DDC_TEST: build_web_compilers: ^2.0.0
#DDC_TEST: build_runner: ^2.1.4
#DDC_TEST: build_test: ^2.1.4
#DDC_TEST: build_web_compilers: ^3.2.1

# The above dependencies are used for running the dartdevc_test task on Travis.
# Since build_runner indirectly depends on quiver, we patch these in at test
Expand Down
5 changes: 1 addition & 4 deletions tool/travis/task.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,7 @@ while (( "$#" )); do
;;
dartdevc_test) echo
echo -e '\033[1mTASK: dartdevc_test\033[22m'
echo -e '*** TEMPORARILY DISABLED ON null_safety branch pending migration on build_* packages'
# TODO(cbracken): Re-enable when build_packages have NNBD releases.
# https://github.com/google/quiver-dart/issues/619
#./tool/travis/ddc_test.sh -p chrome -x fails-on-dartdevc -r expanded || EXIT_CODE=$?
./tool/travis/ddc_test.sh -p chrome -x fails-on-dartdevc -r expanded || EXIT_CODE=$?
;;
*) echo -e "\033[31mUnknown task: '${TASK}'. Error!\033[0m"
EXIT_CODE=1
Expand Down

0 comments on commit 7b4b8cc

Please sign in to comment.