This repository has been archived by the owner on Jul 27, 2018. It is now read-only.
Add goToUrl action creator #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
suggested changes
Jan 15, 2017
| @@ -9,6 +9,7 @@ export interface RouterMethodCall { | |||
|
|
|||
| export const routerActions = { | |||
| GO: '[Router] Go', | |||
| GO_TO_URL: '[Router] Go to URL', | |||
There was a problem hiding this comment.
Change the action to URL instead
| @@ -25,6 +26,12 @@ export function go(path: string|any[], query?: any, extras?: NavigationExtras): | |||
| return { type: routerActions.GO, payload }; | |||
| } | |||
|
|
|||
| export function goToUrl(path: string, extras?: NavigationExtras): Action { | |||
There was a problem hiding this comment.
Change the function name to url
| @@ -22,6 +22,12 @@ export function listenForRouterMethodActions(router: Router, location: Location, | |||
| router.navigate(commands, Object.assign({}, extras, { queryParams })); | |||
| break; | |||
|
|
|||
| case routerActions.GO_TO_URL: | |||
| if (typeof path === 'string') { | |||
There was a problem hiding this comment.
The action is already typed to a string so no need to validate it here.
|
Hello, may I ask why this was closed? Is this feature going to be implemented still? |
|
@mischkl I think because they're concentrating on NGRX 4, which will use the normal router methods not dispatchable actions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30