-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua scenarios where configuration parsed incorrectly #131
base: main
Are you sure you want to change the base?
Conversation
{"{", 3}, | ||
{"print(\"Test lua ssl certificate!\")", 4}, | ||
{"}", 5}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{"\n print(\"Test lua ssl certificate!\")\n ",5},
{";", 5},
We grab everything in the Lua block as a single token and drop the {}. Example:
content_by_lua_block {some code}
will be content_by_lua_block "some code";
"some code" is an argument of directive.
For reference: #86
{"\n print(\"Test lua ssl certificate!\")\n ", 19}, | ||
{")", 20}, | ||
{"}", 21}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{"\n print(\"Test lua ssl certificate!\")\n ", 19}, | |
{")", 20}, | |
{"}", 21}, | |
{"\n print(\"Test lua ssl certificate!\")\n ",21}, |
Proposed changes
An issue was discovered when parsing configurations with
ssl_certificate_by_lua_block
in them. This is intended to add a fix and tests covering those scenariosChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
)