-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove args stub from module template to satisfy language server #3403
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait to merge this until v3.2.0, so we don't have bigger changes in a patch release. I am blocking the merge but changes LGTM 🙂
Fine with me (although arguably a very small change) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to merge now :)
Would it be potentially better to do This has a couple of benefits over dropping the
|
I had thought the same thing as one option @awgymer , but was outvoted https://nfcore.slack.com/archives/C043UU89KKQ/p1737099337825629 |
That is a shame. It seems like people have a different view of the purpose of I wish it would behave more strictly as a "ran the pipeline as if it were real except never actually executed the script" mode. I have had this open issue for some time in nextflow because sometimes you have more complex logic for e.g. determining if you should add a |
Bring it up on the slack channel! I don't mind changing the PR myself :) |
Are normies allowed to join and comment in #team-maintainers 🤔 |
Yes :) |
I don't know if there is a linting check for this though...
People can add it back in if needed within the stub
PR checklist
CHANGELOG.md
is updateddocs
is updated