Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline template: Fix the faulty Download test / GitHub action #3389

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

MatthiasZepper
Copy link
Member

@MatthiasZepper MatthiasZepper commented Jan 8, 2025

In #3351, I refactored the nf-core pipelines download test to use $GITHUB_OUTPUT instead of the environment for improved security.

However, splitting the test into two independent jobs introduced the possibility of them running on different runners, which resulted in the second job lacking the correct setup. I have now resolved this issue by ensuring that all necessary setup setups are retained within the main job. Only the potentially vulnerable step remains isolated from the main job, but also does not require any setup.

The new version of the CI pipeline was successfully tested in my Test pipeline repository. Any further independent tests are highly appreciated.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels added this to the 3.1.2 milestone Jan 9, 2025
@MatthiasZepper MatthiasZepper force-pushed the no_env_in_download_action branch from e03dbc0 to 5aee4b1 Compare January 9, 2025 12:05
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.04%. Comparing base (b685800) to head (c67027d).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatthiasZepper MatthiasZepper marked this pull request as ready for review January 10, 2025 13:18
@MatthiasZepper MatthiasZepper force-pushed the no_env_in_download_action branch from 5aee4b1 to c67027d Compare January 10, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants