Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Conda directive is not honoured by task array #5704

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

pditommaso
Copy link
Member

This PR fixes the usage of conda directive with task arrays.

Solves #5694

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 4f5ad08
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/679265765068780008cf568f
😎 Deploy Preview https://deploy-preview-5704--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bentsherman
Copy link
Member

I need to update the docs for this. I think I didn't include conda in the list because the conda environment is normally handled by the task script. So each task could have a different conda environment. But with Wave, the conda environment needs to be uniform for the process because Wave uses conda to resolve the container image beforehand

Signed-off-by: Ben Sherman <[email protected]>
@bentsherman bentsherman requested a review from a team as a code owner January 23, 2025 15:46
Signed-off-by: Ben Sherman <[email protected]>
@pditommaso pditommaso merged commit f8c3b63 into master Jan 23, 2025
21 checks passed
@pditommaso pditommaso deleted the wave-google-batch-array branch January 23, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Batch job arrays do not play nicely with wave containers built from conda
2 participants