Preserve attributes of published files (take 2) #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
changed the title
|
Tagging @jordeu for visibility? Does Fusion honour the copy of file timestamps? |
|
If the copy attributes is only honoured by local and shared file system, we should consider making this an opt-in feature, because it's not a portable behaviour. In alternative, instead of copying the file stamps, it could be tried to copy the files ordering them by timestamp. Even if the timestamp would be different it may guarantee they are consistent with expectation of the tool reported in the issue (tho is should be verified the the timestamp is set when stating the upload or when it completes). |
|
I don't think re-ordering the publish operations will matter because they are published concurrently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4522
Allow COPY_ATTRIBUTES on S3 copy as a no-op, so that this attribute can be set generically when publishing files.
For some reason this issue did not surface in the previous PR but only once the PR was merged