-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying disk image for additional disk with Google Batch #4535
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hatem Nawar <[email protected]>
Signed-off-by: Hatem Nawar <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ben Sherman <[email protected]>
plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchTaskHandler.groovy
Outdated
Show resolved
Hide resolved
This change by itself is fine, but the disk directive now has three purposes (resize boot disk, attach empty disk, attach disk with image) but can be specified only once. That means that e.g. you couldn't attach a disk with reference inputs and also attack a local SSD to use as scratch storage. To solve this issue we just need to allow the disk directive to be specified multiple times. But I am fine with merging this PR as it is and implementing multiple disk directives in a separate PR. |
Thanks Ben :) I did think about the multiple disk directive, but did not have an answer for that |
New feature
Support specifying a disk image for additional disk when using Google Batch. This would be useful in many cases but particularly with large reference files which can be both time consuming and expensive.
Using DIsk image is faster and cheaper as the Disk is created from the image before the provisioning the VM
Usage scenario
User creates a Disk image containing all reference files
User specifies the image as part of the disk directive in the process
#4534