Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Fusion unprivileged execution #4387

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Support for Fusion unprivileged execution #4387

merged 6 commits into from
Oct 10, 2023

Conversation

pditommaso
Copy link
Member

@pditommaso pditommaso commented Oct 9, 2023

This PR the config option

fusion.privileged = true|false // defualt true

Enable or disable the privileged execution required by Fusion. The implementation depends on the target executor

Signed-off-by: Paolo Di Tommaso <[email protected]>
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 6b61fc8
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/65250927c3ed3e0008dccfa9
😎 Deploy Preview https://deploy-preview-4387--nextflow-docs-staging.netlify.app/fusion
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pditommaso pditommaso requested a review from jordeu October 9, 2023 14:00
@pditommaso pditommaso marked this pull request as draft October 9, 2023 14:00
@pditommaso pditommaso changed the title This PR adds the ability to control the unprivileged execution for Fusion Support for Fusion unprivileged execution Oct 9, 2023
@pditommaso pditommaso marked this pull request as ready for review October 9, 2023 20:39
@pditommaso
Copy link
Member Author

Ready

Signed-off-by: Paolo Di Tommaso <[email protected]>
Copy link
Collaborator

@jordeu jordeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working! 🎉

I've double checked that the pod do not uses privileged mode.

@pditommaso
Copy link
Member Author

Awesome

Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso merged commit 035e6e7 into master Oct 10, 2023
@pditommaso pditommaso deleted the k8s-fuse-v2 branch October 10, 2023 08:20
abhi18av pushed a commit to abhi18av/nextflow that referenced this pull request Oct 28, 2023
This commit allows disabling the privileged container execution
when using the fusion file system. This can be controlled by using the following 
configuration setting: 

```
 fusion.privileged = true|false // default true
``` 

The effective use of this setting depends on the target execution. 
Currently, it's only supported by the Kubernetes executor which
requires the use the k8s-fuse-plugin to be installed in the target cluster 

More details here https://github.com/nextflow-io/k8s-fuse-plugin



Signed-off-by: Paolo Di Tommaso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants