-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove privileged mode with Fusion #4141
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
modules/nextflow/src/main/groovy/nextflow/container/ContainerConfig.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/container/ContainerConfig.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/container/ContainerConfig.groovy
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/k8s/K8sTaskHandler.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Ben Sherman <[email protected]>
Were these changes tested? |
Not yet, just following your and Jordi's suggestions. I can test them later, and try K8s to see if any permissions are not needed. |
This stuff is tricky, and there may be differences across linux and mac implementations. It could even be necessary to implement as an opt-in feature. |
Regarding the testing, haven't all of these changes except for K8s already been tested? I assume you guys tested docker and podman by setting |
I've tried once, but was a kind of mess. Also there have been a lot of changes recently with this problem with the root user, etc. Nothing can be taken for granted |
81f7cb7
to
8a43489
Compare
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
@pditommaso do you still want to merge the non-K8s bits of this PR? |
it would be nice, @jordeu recently wrote some useful guidelines about this
|
Signed-off-by: Paolo Di Tommaso <[email protected]>
@jordeu can you please review this one more time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've double-checked, and everything is working
modules/nextflow/src/main/groovy/nextflow/container/ContainerConfig.groovy
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/container/ContainerConfig.groovy
Show resolved
Hide resolved
Signed-off-by: Paolo Di Tommaso <[email protected]>
It turns out, it does not work on mac
|
With docker or podman? |
Docker |
Are you using Docker Desktop? What version? Can you check the Kernel version (run |
|
Close #3337
Currently includes:
Not sure yet what's needed for Singularity, but there is the
--fusemount
option.Not sure if AWS Batch supports device capabilities for containers. The
--device
option is supported under LinuxParameters and a Device can have permissions READ | WRITE | MKNOD.Waiting for @jordeu to advise on the remaining implementation.