Fix #36340 #50069
Open
Fix #36340 #50069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michiel de Jong <[email protected]>
michielbdejong
force-pushed
the
fix-36340
branch
from
44982b9 to
6aaefe2
Compare
provokateurin
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
LGTM, but you need to change the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/
joshtrichards
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks, @michielbdejong. Please clean-up the commit message and should be good.
| @@ -155,6 +157,7 @@ public function setOwnerDisplayName($ownerDisplayName) { | |||
| */ | |||
| public function setSharedBy($sharedBy) { | |||
| $this->share['sharedBy'] = $sharedBy; | |||
| $this->share['sender'] = $sharedBy; | |||
There was a problem hiding this comment.
Is it a cloudId (Could be read like it should be from https://github.com/cs3org/OCM-API/blob/develop/spec.yaml#L526 ) or the user id?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Copy
sharedByandsharedByDisplayNamefields tosenderandsenderDisplayNameto allow non-Nextcloud implementations of Open Cloud Mesh to find this information when receiving a share from a nextcloud user.Checklist