feat(files_sharing): add send mail toggle #50064
Conversation
nfebe
force-pushed
the
fix/49954/add-send-mail-toggle
branch
from
f178f55 to
4372d7a
Compare
|
Why not put it to true straight away? |
This sounds okay, but should not require another review cycle? cc: @skjnldsv |
For new internal shares, show the user a toggle for them configure if they want to send the share receiver a notification mail. This is subject to wether the configured user has an email send up Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/49954/add-send-mail-toggle
branch
from
4372d7a to
c43bbd2
Compare
| @@ -329,8 +335,8 @@ export default { | |||
| data() { | |||
| return { | |||
| writeNoteToRecipientIsChecked: false, | |||
| sendNotificationMailOnCreation: true, | |||
There was a problem hiding this comment.
| sendNotificationMailOnCreation: true, | |
| sendNotificationMailOnCreation: true, |
|
Being the customer who opened the ticket that lead to the issue #49954, this would not fix our initial problem. Our users have to accept shares, and are used to accept the shares by the link in the mail. Like hier in a gif from our user documentation. The link in the mail directly accepts the share. Now the shares are listed as pending, but users do not find those. They get notifications about changes on shared folders and if they open the internal links from the notfications, they get a file not found error. No mention of the pending shares. Then they contact the support. So i am not against the optional mails presented here in general, but would love an admin option to overrule it and enforce the mails. Kind regards |
Summary
For new internal shares, show the user a toggle for them configure if they want to send the share receiver a notification mail.
This is subject to whether the configured user has an email send up
Screenshots
TODO