Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1419] - Migrate from onCreateOptionMenu to implements MenuProvider #1426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WentuM
Copy link

@WentuM WentuM commented May 10, 2024

Implements MenuProvider instead of use onCreateOptionMenu (deprecated)

@David-Development
Copy link
Member

@WentuM Sorry for the delay - had some personal things to take care of! Thank you for contributing to this app!
I've reviewed and tested the changes (which are looking great) - unfortunately it's not working for me - the app doesn't have any menus anymore. It looks like that the call to addMenuProvider(this, this); in the Activities onCreate method is missing. Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants