Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favIconHandler's context on RssItemViewHolder bind #1405

Closed
wants to merge 2 commits into from
Closed

Update favIconHandler's context on RssItemViewHolder bind #1405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd55d71
Update context on bind
DoHe Mar 30, 2024
47f6b72
Check for context equality
DoHe Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/adapter/RssItemViewHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ public void bind(@NonNull RssItem rssItem) {


ImageView imgViewFavIcon = getImageViewFavIcon();
favIconHandler.setContext(itemView.getContext());
if (imgViewFavIcon != null) {
favIconHandler.loadFavIconForFeed(favIconUrl, imgViewFavIcon, Math.round((marginFavIcon - sizeOfFavIcon) / 2f));
}
Expand Down
12 changes: 10 additions & 2 deletions News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/helper/FavIconHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
public class FavIconHandler {
private static final String TAG = FavIconHandler.class.getCanonicalName();

private final RequestManager mGlide;
private final Context mContext;
private RequestManager mGlide;
private Context mContext;
private final int mPlaceHolder;

public FavIconHandler(Context context) {
Expand Down Expand Up @@ -155,4 +155,12 @@ private void UpdateAvgColorOfFeed(long feedId, Bitmap bitmap, Context context) {
Log.v(TAG, "Failed to update AVG color of feed: " + feedId);
}
}

public void setContext(Context context) {
if (context == mContext) {
return;
}
mContext = context;
mGlide = Glide.with(context);
}
}