Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar placeholder renders white on white in light theme #1306

Conversation

cemrich
Copy link
Contributor

@cemrich cemrich commented Oct 29, 2023

Icon color now matches those of action icons in all themes.

Tested with and without user avatars set in nextcloud.

Tested with and without user avatars set in nextcloud

Signed-off-by: Christine Coenen <[email protected]>
Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't one use ?attr/colorOnSurfaceVariant instead of ?colorOnSurfaceVariant?

@cemrich
Copy link
Contributor Author

cemrich commented Oct 29, 2023

Shouldn't one use ?attr/colorOnSurfaceVariant instead of ?colorOnSurfaceVariant?

It should be the same in this case: https://developer.android.com/guide/topics/resources/providing-resources#ReferencesToThemeAttributes

@David-Development David-Development merged commit 28ab4a8 into nextcloud:master Oct 31, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants