Fix inaccurate scroll bar due to lazy loading #1232

Signed-off-by: Christine Coenen <[email protected]>
nextcloud · Jul 4, 2024 · 1c5de87 · 1c5de87
1 parent 7eb5d58
commit 1c5de87
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 8 deletions.
diff --git a/...-Android-App/src/main/java/de/luhmer/owncloudnewsreader/LazyLoadingLinearLayoutManager.kt b/...-Android-App/src/main/java/de/luhmer/owncloudnewsreader/LazyLoadingLinearLayoutManager.kt
@@ -0,0 +1,23 @@
+package de.luhmer.owncloudnewsreader
+
+import android.content.Context
+import androidx.recyclerview.widget.LinearLayoutManager
+import androidx.recyclerview.widget.RecyclerView
+import kotlin.math.roundToInt
+
+class LazyLoadingLinearLayoutManager(
+	context: Context?,
+	@RecyclerView.Orientation orientation: Int,
+	reverseLayout: Boolean
+) : LinearLayoutManager(context, orientation, reverseLayout) {
+
+	var totalItemCount: Int = 0
+
+	override fun computeVerticalScrollRange(state: RecyclerView.State): Int {
+		if (state.itemCount == 0) {
+			return 0
+		}
+
+		return (super.computeVerticalScrollRange(state) / state.itemCount.toFloat() * totalItemCount).roundToInt()
+	}
+}
diff --git a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java
@@ -326,7 +326,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
         binding = FragmentNewsreaderDetailBinding.inflate(inflater, container, false);
 
         binding.list.setHasFixedSize(true);
-        binding.list.setLayoutManager(new LinearLayoutManager(mActivity, RecyclerView.VERTICAL, false));
+        binding.list.setLayoutManager(new LazyLoadingLinearLayoutManager(mActivity, RecyclerView.VERTICAL, false));
         binding.list.setItemAnimator(new DefaultItemAnimator());
 
         ItemTouchHelper itemTouchHelper = new ItemTouchHelper(new NewsReaderItemTouchHelperCallback());

diff --git a/...droid-App/src/main/java/de/luhmer/owncloudnewsreader/adapter/NewsListRecyclerAdapter.java b/...droid-App/src/main/java/de/luhmer/owncloudnewsreader/adapter/NewsListRecyclerAdapter.java
@@ -10,7 +10,6 @@
 
 import androidx.annotation.NonNull;
 import androidx.fragment.app.FragmentActivity;
-import androidx.recyclerview.widget.LinearLayoutManager;
 import androidx.recyclerview.widget.RecyclerView;
 
 import com.bumptech.glide.Glide;
@@ -24,6 +23,7 @@
 
 import de.luhmer.owncloudnewsreader.NewsReaderListActivity;
 import de.luhmer.owncloudnewsreader.SettingsActivity;
+import de.luhmer.owncloudnewsreader.LazyLoadingLinearLayoutManager;
 import de.luhmer.owncloudnewsreader.database.DatabaseConnectionOrm;
 import de.luhmer.owncloudnewsreader.database.model.RssItem;
 import de.luhmer.owncloudnewsreader.databinding.ProgressbarItemBinding;
@@ -68,6 +68,8 @@ public class NewsListRecyclerAdapter extends RecyclerView.Adapter<RecyclerView.V
     private final int visibleThreshold = 5;
     private final SharedPreferences mPrefs;
 
+    private LazyLoadingLinearLayoutManager layoutManager = null;
+
     public NewsListRecyclerAdapter(FragmentActivity activity, RecyclerView recyclerView, IPlayPausePodcastClicked playPausePodcastClicked, PostDelayHandler postDelayHandler, SharedPreferences prefs) {
         this.activity = activity;
         this.playPausePodcastClicked = playPausePodcastClicked;
@@ -82,7 +84,8 @@ public NewsListRecyclerAdapter(FragmentActivity activity, RecyclerView recyclerV
 
         EventBus.getDefault().register(this);
 
-        if (recyclerView.getLayoutManager() instanceof LinearLayoutManager linearLayoutManager) {
+        if (recyclerView.getLayoutManager() instanceof LazyLoadingLinearLayoutManager lm) {
+            layoutManager = lm;
 
             recyclerView
                     .addOnScrollListener(new RecyclerView.OnScrollListener() {
@@ -91,8 +94,8 @@ public void onScrolled(@NonNull RecyclerView recyclerView,
                                                int dx, int dy) {
                             super.onScrolled(recyclerView, dx, dy);
 
-                            int adapterTotalItemCount = linearLayoutManager.getItemCount();
-                            int lastVisibleItem = linearLayoutManager
+                            int adapterTotalItemCount = layoutManager.getItemCount();
+                            int lastVisibleItem = layoutManager
                                     .findLastVisibleItemPosition();
                             if (!loading &&
                                     adapterTotalItemCount <= (lastVisibleItem + visibleThreshold) &&
@@ -131,6 +134,10 @@ public int getCachedPages() {
 
     public void setTotalItemCount(int totalItemCount) {
         this.totalItemCount = totalItemCount;
+
+        if (this.layoutManager != null) {
+            this.layoutManager.setTotalItemCount(totalItemCount);
+        }
     }
 
     public void setCachedPages(int cachedPages) {
@@ -384,7 +391,7 @@ public void updateAdapterData(List<RssItem> rssItems) {
         //}
         //new ReloadAdapterAsyncTask().execute();
 
-        totalItemCount = ((Long) dbConn.getCurrentRssItemViewCount()).intValue();
+        setTotalItemCount(((Long) dbConn.getCurrentRssItemViewCount()).intValue());
 
         lazyList = rssItems;
         notifyDataSetChanged();
@@ -492,9 +499,9 @@ protected CurrentRssViewDataHolder doInBackground(Void... params) {
         @Override
         protected void onPostExecute(CurrentRssViewDataHolder holder) {
             lazyList = holder.rssItems;
-            totalItemCount = holder.maxCount.intValue();
+            setTotalItemCount(holder.maxCount.intValue());
             cachedPages = 1;
             notifyDataSetChanged();
         }
     }
-}
+}