-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update R8/ProGuard section of README.md #635
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion on this.
I think some breakages in downstream apps caused by obfuscation could be fixed in this library. But would require a lot effort/time to narrow down.
Thats why I personally wouldn't advertise using "will automatically work without additional app level rules".
This is partially covered with line 286, though.
Are there known breakages in downstream apps? For the two apps I worked with it was fine. |
The news app had crashes related to sso with obfuscation enabled last time I tested. In case you try to reproduce: |
I built the news-android app without |
I'd call |
Oh that are the application classes, I was looking for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no known broken downstream apps anymore this can be merged
Signed-off-by: Konrad Pozniak <[email protected]>
fabc529
to
b03258b
Compare
closes #572