Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(modules): add a new module for golden signal alerts based on newrelic_nrql_alert_condition #2715

Merged
merged 5 commits into from
Jul 22, 2024
Merged

chore(modules): add a new module for golden signal alerts based on newrelic_nrql_alert_condition #2715

merged 5 commits into from
Jul 22, 2024

Conversation

shashank-reddy-nr
Copy link
Contributor

@shashank-reddy-nr shashank-reddy-nr commented Jul 16, 2024 •
edited by pranav-new-relic
Loading

Description

As the GitHub issue states #2686, the current module we have for golden signal alerts in the Terraform Provider’s repository is obsolete, as it comprises references to legacy alert conditions which are now deprecated. Hence, the ask is to have references of legacy alert conditions in the module moved to newrelic_nrql_alert_condition.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

@pranav-new-relic
Copy link
Member

pranav-new-relic commented Jul 17, 2024 •
edited
Loading

@shashank-reddy-nr please also run a terraform fmt on both of these modules which would help format Terraform configuration in all *.tf files

@pranav-new-relic
Copy link
Member

@shashank-reddy-nr let's call the module golden-signal-alerts-new and not new-golden-signal-alerts

@pranav-new-relic pranav-new-relic marked this pull request as draft July 19, 2024 05:21
@pranav-new-relic pranav-new-relic marked this pull request as ready for review July 19, 2024 15:46
@pranav-new-relic pranav-new-relic changed the title fix(golden-alerts): Add a New Module for Golden Signal Alerts based on newrelic_nrql_alert_condition chore(modules): add a new module for golden signal alerts based on newrelic_nrql_alert_condition Jul 22, 2024
@pranav-new-relic pranav-new-relic merged commit a9e194c into main Jul 22, 2024
13 of 14 checks passed
@pranav-new-relic pranav-new-relic deleted the NR-287599 branch July 22, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranav-new-relic pranav-new-relic pranav-new-relic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashank-reddy-nr @pranav-new-relic