Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(notifications): changed jira example comment #2691

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

amaor-newrelic
Copy link
Contributor

Description

This is just a short documentation update to make a specific example clearer

@vagrawal-newrelic vagrawal-newrelic self-requested a review September 2, 2024 11:43
Copy link
Contributor

@vagrawal-newrelic vagrawal-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. No issues found

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.48%. Comparing base (92361de) to head (e893f9e).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2691      +/-   ##
==========================================
+ Coverage   32.82%   36.48%   +3.65%     
==========================================
  Files          98       99       +1     
  Lines       26884    21964    -4920     
==========================================
- Hits         8824     8013     -811     
+ Misses      17902    13787    -4115     
- Partials      158      164       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ amaor-newrelic
❌ vagrawal-newrelic
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ amaor-newrelic
❌ vagrawal-newrelic
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@vagrawal-newrelic vagrawal-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with small update in PR. Removed the hyperlink block as it is not being rendered in the comment section in markdown file.

@vagrawal-newrelic vagrawal-newrelic merged commit 6640ecb into newrelic:main Sep 2, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants