fix: Handle monitorID error not found #2640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abasha1234 the changes good look to me. Can you please also add a test case (with an invalid monitor ID in the entities field) and validate the error being thrown? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes for throwing an error as
invalid monitor IDwhen an invalid monitor ID is provided for the resourcenewrelic_synthetics_multilocation_alert_condition.Ticket : https://new-relic.atlassian.net/browse/NR-257490
Fixes # (issue)
Issue: #2631
Checklist:
Please delete options that are not relevant.