Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(destinations): add new fields to destinations; secureUrl, custom headers auth and more #2635

Merged

Conversation

nzur-newrelic
Copy link
Contributor

@nzur-newrelic nzur-newrelic commented Apr 11, 2024

Description

This PR adds logic in regards to 2 new fields on destinations.
Custom Headers Auth- Another type of auth, which uses a list of key values.
SecureUrl- A new and secure way to add url to your destination, now separated into a a non-secure prefix and a secure suffix.
Please include a summary of the change and which issue is fixed (if relevant).

Requires newrelic/newrelic-client-go#1122

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

@nzur-newrelic nzur-newrelic marked this pull request as ready for review April 11, 2024 09:49
chore: update to latest client-go version
@pranav-new-relic pranav-new-relic force-pushed the add-destination-new-fields branch from 52a51ac to edb4a02 Compare April 11, 2024 10:15
@pranav-new-relic pranav-new-relic changed the title Add destination new fields feat(destinations): add new fields to destinations; secureUrl, custom headers auth and more Apr 11, 2024
go.mod Outdated Show resolved Hide resolved
@pranav-new-relic pranav-new-relic merged commit afc2cdf into newrelic:main Apr 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants