-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(destinations): add new fields to destinations; secureUrl, custom headers auth and more #2635
Merged
pranav-new-relic
merged 11 commits into
newrelic:main
from
nzur-newrelic:add-destination-new-fields
Apr 22, 2024
Merged
feat(destinations): add new fields to destinations; secureUrl, custom headers auth and more #2635
pranav-new-relic
merged 11 commits into
newrelic:main
from
nzur-newrelic:add-destination-new-fields
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: update to latest client-go version
pranav-new-relic
force-pushed
the
add-destination-new-fields
branch
from
April 11, 2024 10:15
52a51ac
to
edb4a02
Compare
pranav-new-relic
changed the title
Add destination new fields
feat(destinations): add new fields to destinations; secureUrl, custom headers auth and more
Apr 11, 2024
newrelic/data_source_newrelic_notifications_destination_test.go
Outdated
Show resolved
Hide resolved
pranav-new-relic
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logic in regards to 2 new fields on destinations.
Custom Headers Auth- Another type of auth, which uses a list of key values.
SecureUrl- A new and secure way to add url to your destination, now separated into a a non-secure prefix and a secure suffix.
Please include a summary of the change and which issue is fixed (if relevant).
Requires newrelic/newrelic-client-go#1122
Type of change
Please delete options that are not relevant.
Checklist:
Please delete options that are not relevant.
How to test this change?
Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc