Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Host Not Reporting as NRQL conditions #2630

Closed
wants to merge 1 commit into from

Conversation

baNROne
Copy link
Contributor

@baNROne baNROne commented Apr 3, 2024

Description

Add support for configuring Host Not Reporting conditions as NRQL conditions.
https://new-relic.atlassian.net/browse/NR-232401

NRQL Alert conditions will be receiving a new feature. Users will be able to use NRQL alert conditions to notify when New Relic stopped receiving data from an infrastructure agent.

The boolean on the expiration field will not trigger alerts for hosts that perform a clean shutdown option

This PR adds the boolean infra_host_clean_shutdown to the newrelic_nrql_alert_condition resource. By default it is set to false at our API level.

Please do not merge until merging this change for the Go client: newrelic/newrelic-client-go#1111

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.TF

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2024

CLA assistant check
All committers have signed the CLA.

@pranav-new-relic
Copy link
Member

Thank you for the code addition, @baNROne :)

Please do not merge until merging this change for the Go client: newrelic/newrelic-client-go#1111

acknowledged 👍

@baNROne
Copy link
Contributor Author

baNROne commented Apr 23, 2024

We're reevaluating our approach to this project. Closing this out for now.

@baNROne baNROne closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants