chore: add tests and final edits

newrelic · Dec 11, 2023 · 14bda88 · 14bda88
1 parent 688c7cd
commit 14bda88
Show file tree

Hide file tree

Showing 3 changed files with 438 additions and 43 deletions.
diff --git a/newrelic/resource_newrelic_monitor_downtime.go b/newrelic/resource_newrelic_monitor_downtime.go
@@ -168,7 +168,7 @@ func resourceNewRelicMonitorDowntimeCreate(ctx context.Context, d *schema.Resour
 	}
 
 	switch commonArgumentsObject.Mode {
-	case "ONE_TIME":
+	case SyntheticsMonitorDowntimeModes.ONE_TIME:
 		oneTimeCreateObject, err := getMonitorDowntimeOneTimeValues(d, commonArgumentsObject)
 		if err != nil {
 			return diag.FromErr(err)
@@ -182,7 +182,7 @@ func resourceNewRelicMonitorDowntimeCreate(ctx context.Context, d *schema.Resour
 
 		d.SetId(guid)
 		break
-	case "DAILY":
+	case SyntheticsMonitorDowntimeModes.DAILY:
 		dailyCreateObject, err := getMonitorDowntimeDailyValues(d, commonArgumentsObject)
 		if err != nil {
 			return diag.FromErr(err)
@@ -196,7 +196,7 @@ func resourceNewRelicMonitorDowntimeCreate(ctx context.Context, d *schema.Resour
 
 		d.SetId(guid)
 		break
-	case "WEEKLY":
+	case SyntheticsMonitorDowntimeModes.WEEKLY:
 		weeklyCreateObject, err := getMonitorDowntimeWeeklyValues(d, commonArgumentsObject)
 		if err != nil {
 			return diag.FromErr(err)
@@ -210,7 +210,7 @@ func resourceNewRelicMonitorDowntimeCreate(ctx context.Context, d *schema.Resour
 
 		d.SetId(guid)
 		break
-	case "MONTHLY":
+	case SyntheticsMonitorDowntimeModes.MONTHLY:
 		monthlyCreateObject, err := getMonitorDowntimeMonthlyValues(d, commonArgumentsObject)
 		if err != nil {
 			return diag.FromErr(err)
@@ -261,22 +261,21 @@ func resourceNewRelicMonitorDowntimeRead(ctx context.Context, d *schema.Resource
 	mode := setMonitorDowntimeMode(tags)
 	timezone := setMonitorDowntimeTimezone(tags)
 	_ = d.Set("name", entity.GetName())
-	_ = d.Set("monitor_guids", setMonitorDowntimeMonitorGUIDs(entity.GetRelationships(), common.EntityGUID(d.Id())))
 	_ = d.Set("account_id", setMonitorDowntimeAccountId(tags))
 	_ = d.Set("mode", mode)
 	_ = d.Set("start_time", setMonitorDowntimeStartTime(tags))
 	_ = d.Set("end_time", setMonitorDowntimeEndTime(tags))
 	_ = d.Set("time_zone", timezone)
 
-	if mode != "ONE_TIME" {
+	if mode != SyntheticsMonitorDowntimeModes.ONE_TIME {
 		setMonitorDowntimeEndRepeat(d, tags, timezone)
 	}
 
-	if mode == "WEEKLY" {
+	if mode == SyntheticsMonitorDowntimeModes.WEEKLY {
 		setMonitorDowntimeMaintenanceDays(d, tags)
 	}
 
-	if mode == "MONTHLY" {
+	if mode == SyntheticsMonitorDowntimeModes.MONTHLY {
 		setMonitorDowntimeFrequency(d, tags)
 	}
 	return nil
@@ -292,7 +291,7 @@ func resourceNewRelicMonitorDowntimeUpdate(ctx context.Context, d *schema.Resour
 	}
 
 	switch commonArgumentsObject.Mode {
-	case "ONE_TIME":
+	case SyntheticsMonitorDowntimeModes.ONE_TIME:
 		oneTimeUpdateObject, err := getMonitorDowntimeOneTimeValues(d, commonArgumentsObject)
 		if err != nil {
 			return diag.FromErr(err)
@@ -306,7 +305,7 @@ func resourceNewRelicMonitorDowntimeUpdate(ctx context.Context, d *schema.Resour
 
 		d.SetId(guid)
 		break
-	case "DAILY":
+	case SyntheticsMonitorDowntimeModes.DAILY:
 		dailyUpdateObject, err := getMonitorDowntimeDailyValues(d, commonArgumentsObject)
 		if err != nil {
 			return diag.FromErr(err)
@@ -320,7 +319,7 @@ func resourceNewRelicMonitorDowntimeUpdate(ctx context.Context, d *schema.Resour
 
 		d.SetId(guid)
 		break
-	case "WEEKLY":
+	case SyntheticsMonitorDowntimeModes.WEEKLY:
 		weeklyUpdateObject, err := getMonitorDowntimeWeeklyValues(d, commonArgumentsObject)
 		if err != nil {
 			return diag.FromErr(err)
@@ -334,7 +333,7 @@ func resourceNewRelicMonitorDowntimeUpdate(ctx context.Context, d *schema.Resour
 
 		d.SetId(guid)
 		break
-	case "MONTHLY":
+	case SyntheticsMonitorDowntimeModes.MONTHLY:
 		monthlyUpdateObject, err := getMonitorDowntimeMonthlyValues(d, commonArgumentsObject)
 		if err != nil {
 			return diag.FromErr(err)