feat(alerts): add support for titleTemplate to NRQL alert conditions
#1141
Conversation
pkg/alerts/nrql_conditions.go
Outdated
| @@ -273,6 +275,7 @@ type NrqlConditionUpdateBase struct { | |||
| ViolationTimeLimitSeconds int `json:"violationTimeLimitSeconds,omitempty"` | |||
| Expiration *AlertsNrqlConditionExpiration `json:"expiration,omitempty"` | |||
| Signal *AlertsNrqlConditionUpdateSignal `json:"signal"` | |||
| IncidentTitleTemplate *string `json:"incidentTitleTemplate,omitempty"` | |||
There was a problem hiding this comment.
@baNROne I think we'll want to leave off omitempty for NrqlConditionUpdateBase. The reason is because we want a user to be able to remove an incident title template on an existing condition that already has the field configured. This presentation (slides 20-25 particularly) does a great job at explaining the reasoning. https://docs.google.com/presentation/d/1VEYfI7acg8LH_uGHjj5Su4RoF1lQRPVyfxK59xUMxV8/edit?usp=sharing
There was a problem hiding this comment.
Makes sense. Thanks @akane0915. I've updated it.
baNROne
changed the title
baNROne
force-pushed
the
add-incident-title-template-support
branch
from
817de1a to
03c6197
Compare
fix: Remove omitempty refactor(alerts): Change field name
baNROne
force-pushed
the
add-incident-title-template-support
branch
from
03c6197 to
df71d2d
Compare
pranav-new-relic
changed the title
titleTemplate to NRQL alert conditions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
- Coverage 38.84% 38.40% -0.44%
==========================================
Files 86 96 +10
Lines 5612 4822 -790
==========================================
- Hits 2180 1852 -328
+ Misses 3266 2795 -471
- Partials 166 175 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
https://new-relic.atlassian.net/browse/NR-74508
Adds support for
titleTemplateCleaned up some formatting while I was in there
See this PR for related changes in the Terraform provider: feat(alerts): Add incident title template support terraform-provider-newrelic#2662
Please do not merge yet