Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new docker FIPS images #1982

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Create new docker FIPS images #1982

merged 1 commit into from
Jan 8, 2025

Conversation

alvarocabanas
Copy link
Contributor

Create new FIPS images

@alvarocabanas alvarocabanas requested a review from a team as a code owner January 3, 2025 16:39
@coveralls
Copy link

coveralls commented Jan 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12651035135

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.321%
Totals Coverage Status
Change from base Build 12651007870: 0.0%
Covered Lines: 15358
Relevant Lines: 26793
💛 - Coveralls

@alvarocabanas alvarocabanas force-pushed the NR_354207_fips_image branch 2 times, most recently from c97d17a to 2da1ff4 Compare January 7, 2025 11:34
rubenruizdegauna
rubenruizdegauna approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from NR_268779_fips_molecule_tests to NR_351326_linux_prerelease_fips January 7, 2025 11:42
Base automatically changed from NR_351326_linux_prerelease_fips to feat/fips January 7, 2025 11:51
rajrohanyadav
rajrohanyadav approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rajrohanyadav rajrohanyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alvarocabanas alvarocabanas merged commit 69e3f6c into feat/fips Jan 8, 2025
22 checks passed
@alvarocabanas alvarocabanas deleted the NR_354207_fips_image branch January 8, 2025 11:28
rajrohanyadav pushed a commit that referenced this pull request Jan 9, 2025
@alvarocabanas @rajrohanyadav
Create new docker FIPS images (#1982)
fb4bec6
rajrohanyadav pushed a commit that referenced this pull request Jan 9, 2025
@alvarocabanas @rajrohanyadav
Create new docker FIPS images (#1982)
52d56fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajrohanyadav rajrohanyadav rajrohanyadav approved these changes

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvarocabanas @coveralls @rubenruizdegauna @rajrohanyadav