-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pull trivy DB from public AWS ECR #84
Conversation
on: | ||
schedule: | ||
- cron: '0 0 * * *' # Update daily at 00:00 - before scheduled trivy scan | ||
workflow_dispatch: # Allow manual triggering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to make it reusable you should add
on:
workflow_call:
inputs: [...] # not sure if these are needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 If we make this reusable, we we'll also need to open 20+ PRs for all the repositories using them, right? I guess we cannot have a cross-repo cache...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these PRs need to be open as well to reference this one, yes 🫠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 1f03e76
from the Aqua Security (Trivy maintainers) verified account
I checked another workaround that does not require opening PRs in all integrations. Added in commit bb741a1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
We'll need to move v3
tag when this is merged
No description provided.