Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Switch to codecov #381

Merged
merged 5 commits into from
Nov 27, 2024
Merged

[CI] Switch to codecov #381

merged 5 commits into from
Nov 27, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Nov 19, 2024

Changes proposed in this pull request:

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass
  • If the PR changes the SPARQL query template, the default Neurobagel query file has also been regenerated

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Summary by Sourcery

CI:

  • Switch from Coveralls to Codecov for code coverage reporting in the CI workflow.

Copy link

sourcery-ai bot commented Nov 19, 2024

Reviewer's Guide by Sourcery

This PR switches the code coverage reporting service from Coveralls to Codecov. The implementation involves updating the GitHub Actions workflow file to remove Coveralls integration and add Codecov integration.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replace Coveralls with Codecov for code coverage reporting
  • Remove workflow_dispatch trigger from GitHub Actions workflow
  • Remove Coveralls GitHub Action and its configuration
  • Add Codecov upload action with token configuration
  • Remove explicit coverage report generation steps
.github/workflows/test.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@surchs surchs added the skip-release PR doesn't appear in the changelog and preserves current version when merged label Nov 19, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @surchs - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR removes the test execution and coverage generation steps. These need to be retained before the Codecov upload - otherwise there won't be any coverage data to report.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Nov 19, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@alyssadai alyssadai self-requested a review November 21, 2024 03:33
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two 🍒, otherwise🧑‍🍳!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@alyssadai
Copy link
Contributor

Also, as in the other PR - how about the [CI] PR label instead? :)

README.md Show resolved Hide resolved
@surchs surchs changed the title [MNT] Switch to codecov [CI] Switch to codecov Nov 27, 2024
@surchs surchs merged commit 0fc4a63 into main Nov 27, 2024
9 checks passed
@surchs surchs deleted the switch_to_codecov branch November 27, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release PR doesn't appear in the changelog and preserves current version when merged
Projects
Status: Review - Done
Development

Successfully merging this pull request may close these issues.

2 participants