-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Switched to lifespan events #287
Conversation
Signed-off-by: samadpls <[email protected]>
This reverts commit 27c1488.
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Pull Request Test Coverage Report for Build 8746974931Details
💛 - Coveralls |
@alyssadai , could you please review it whenever its convenient for you… |
Hey @samadpls, thanks a lot for your PR, and sorry for the very long delay in review. The dev team has been unusually swamped over the past while given some urgent internal project tasks. One of the maintainers get back to you as soon as we can. Thanks so much for your patience! |
Closing this PR due to its inactive status. I'd love to continue working on it if it receives reviews in the future. Thank you for the opportunity😊 |
@samadpls hey, that's fair - sorry this didn't work out as quickly as we would have liked here. We aim to have reviews come in quicker normally, but I think your PR slipped through the cracks because it was a busy time with many priorities. Please do stay in touch and feel very welcome to contribute again on our repos! We'll make sure to stay on top of this in the future (we now have a "Community" section in our project board to help with that). |
Changes proposed in this pull request:
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: