Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting up Phase 1 Refactor Work to Allow Passage Through to Categorization Page #318

Closed
wants to merge 12 commits into from

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Jan 20, 2023

This PR represents a kind of glue between the two phases of our store refactor for the annotation tool. The overall goal was to produce a version of the tool that is working up to the categorization page.

As such there are a number of varied tasks which are described in the issues below. Generally, they cover:

  1. The addition of store fields/methods that were not added during the initial refactor for various reasons
  2. Nominal refactor changes like name changes
  3. Ensuring proper initialization of store fields and loading of the data table/data dictionary
  4. Further adapting navigation/page accessibility code
  5. Updating the pages and their components as needed to ensure the new workflow functions (upload table -> upload dictionary (optional, but not before data table upload) -> go to categorization page, etc.)
  6. Components functioning at least to the point where they don't break the app when loaded on their respective page.

The specific issues covered are listed in #251, but the relevant ones are re-listed below for convenience.

There remain several bugs, the consequence of which mostly do not interfere with the general goal of a working app up to the categorization page. They are:

@jarmoza jarmoza added categorization page landing page data store refactor Simplifying or restructuring existing code or documentation. labels Jan 20, 2023
@jarmoza jarmoza requested a review from surchs January 20, 2023 21:41
@jarmoza jarmoza added this to the v0.1.0 milestone Jan 20, 2023
@jarmoza jarmoza marked this pull request as draft January 23, 2023 16:42
@jarmoza
Copy link
Contributor Author

jarmoza commented Jan 23, 2023

@surchs Standby for check/fix on failed component test(s)

@jarmoza
Copy link
Contributor Author

jarmoza commented Jan 23, 2023

@surchs Could you put an eye on https://github.com/neurobagel/annotation_tool/blob/jarmoza-308/cypress/component/category-select-table.cy.js ? I've been scratching my head as to why this is failing.

[Edit: @surchs Nevermind. I figured it out. The new colorInfo of the store state needed to be mocked. It was odd because the error was occurring past the test itself.]

@surchs
Copy link
Contributor

surchs commented Jan 24, 2023

Glad you resolved the issue @jarmoza, sorry it took me so long to check it out. Would you mind pushing your fix?

@jarmoza
Copy link
Contributor Author

jarmoza commented Jan 26, 2023

This PR will be closed without merge once all tasks in #251 for phase 1 refactor are complete.

@jarmoza
Copy link
Contributor Author

jarmoza commented Jan 31, 2023

I am closing this now that the Phase 1 refactor work has been completed by PRs separating (and improving upon) this one - last one is #330 for reference.

@jarmoza jarmoza closed this Jan 31, 2023
@jarmoza jarmoza deleted the jarmoza-308 branch January 31, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categorization page data store landing page refactor Simplifying or restructuring existing code or documentation.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants