-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connecting up Phase 1 Refactor Work to Allow Passage Through to Categorization Page #318
Conversation
@surchs Standby for check/fix on failed component test(s) |
@surchs Could you put an eye on https://github.com/neurobagel/annotation_tool/blob/jarmoza-308/cypress/component/category-select-table.cy.js ? I've been scratching my head as to why this is failing. [Edit: @surchs Nevermind. I figured it out. The new |
Glad you resolved the issue @jarmoza, sorry it took me so long to check it out. Would you mind pushing your fix? |
This PR will be closed without merge once all tasks in #251 for phase 1 refactor are complete. |
I am closing this now that the Phase 1 refactor work has been completed by PRs separating (and improving upon) this one - last one is #330 for reference. |
This PR represents a kind of glue between the two phases of our store refactor for the annotation tool. The overall goal was to produce a version of the tool that is working up to the categorization page.
As such there are a number of varied tasks which are described in the issues below. Generally, they cover:
The specific issues covered are listed in #251, but the relevant ones are re-listed below for convenience.
There remain several bugs, the consequence of which mostly do not interfere with the general goal of a working app up to the categorization page. They are: