Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix security issues #40

Merged
merged 1 commit into from
Dec 31, 2024
Merged

chore: fix security issues #40

merged 1 commit into from
Dec 31, 2024

Conversation

leoparente
Copy link
Contributor

No description provided.

@leoparente leoparente self-assigned this Dec 31, 2024
@github-actions GitHub Actions
Copy link

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.02s github.com/netboxlabs/orb-agent/agent 0.0% 1 0 0
🟢 PASS 0.26s github.com/netboxlabs/orb-agent/agent/backend 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 0.0% 0 0 0
🟢 PASS 1.02s github.com/netboxlabs/orb-agent/agent/backend/otel 9.7% 2 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/config 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policies 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/policyMgr 0.0% 0 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 2.3%

mfiedorowicz
mfiedorowicz approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two CodeQL issues seem like false positive as api keys are obfuscated

@leoparente leoparente merged commit 5cd0339 into develop Dec 31, 2024
5 checks passed
@leoparente leoparente deleted the chore/OBS-634-security-issues branch December 31, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@ltucker ltucker Awaiting requested review from ltucker

Assignees

@leoparente leoparente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoparente @mfiedorowicz