added useQuote hook #88
Conversation
| const fetcher = (url: string) => fetch(import.meta.env.VITE_NEPALBHASA_API_URL + url, { | ||
| }).then(r => r.json()) | ||
| const useNewari = (props: Omit<DictionaryProps, "language">) => { | ||
| let { data, error, isLoading } = useSWR( |
There was a problem hiding this comment.
looks like your branch might be out of date - can you merge in main into this branch (or rebase) ?
There was a problem hiding this comment.
Can we reformat this into .csv format? I think that will make it easier to edit - eg open in excel etc
There was a problem hiding this comment.
'small' change? well wouldn't it mean reshaping the whole code 😭? I will try to do that tho!
There was a problem hiding this comment.
you did it! it looks good, just looks like you have a little bit of stale logic here
There was a problem hiding this comment.
Yeah our bad, we should have made sure it was a CSV beforehand.
Deploying nepalingo with
|
| Latest commit: |
a7991a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0afb0346.nepalingo.pages.dev |
| Branch Preview URL: | https://quote-hook.nepalingo.pages.dev |
| return { | ||
| text: text ? text.trim() : "", | ||
| translation: translation ? translation.trim() : "", | ||
| text: text ? text.trim().replace(/(^"|"$)/g, "") : "", |
There was a problem hiding this comment.
I don't think you need this anymore right? there are no | separators?
There was a problem hiding this comment.
you did it! it looks good, just looks like you have a little bit of stale logic here
|
Closing because these changes got merged in the #91 PR |
I tried a bunch of methods but this is the only one that worked. it works but it prints the quote 2 times, I couldn't figure out why.
also moved tajpuriyaquotes.txt to src/quotes/ and renamed it 'tajpuriya.txt' cuz otherwise the path of it from hook would be complex.