-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
immplemented change language to flahscards and dictionary #154
Conversation
Deploying nepalingo with Cloudflare Pages
|
const { data, isLoading, error } = useDictionary({ | ||
language: "newari", | ||
word, | ||
}); | ||
const tajpuriyaWord = getTajpuriya(trigger); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of putting this here, can we modify useDictionary
? It should be able to take in a different language. Otherwise you are going to get both the newari and the tajpuriya word even if it's not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated a couple things, made the simplified the logic and made it re-usable. Checkout how short DictionaryPage is!
No description provided.