Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immplemented change language to flahscards and dictionary #154

Merged
merged 13 commits into from
Jul 28, 2024

Conversation

NancyAanchal
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Jul 25, 2024

Deploying nepalingo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 708359d
Status: ✅  Deploy successful!
Preview URL: https://5a2ad7da.nepalingo.pages.dev
Branch Preview URL: https://tajpuiya-flahscards.nepalingo.pages.dev

View logs

const { data, isLoading, error } = useDictionary({
language: "newari",
word,
});
const tajpuriyaWord = getTajpuriya(trigger);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of putting this here, can we modify useDictionary? It should be able to take in a different language. Otherwise you are going to get both the newari and the tajpuriya word even if it's not needed

Copy link
Member

@binamkayastha binamkayastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated a couple things, made the simplified the logic and made it re-usable. Checkout how short DictionaryPage is!

@binamkayastha binamkayastha merged commit 33ad9ed into main Jul 28, 2024
2 checks passed
@binamkayastha binamkayastha deleted the tajpuiya-flahscards branch July 28, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tajpuria functionality. Changing language should change the flashcards and the dictionary search
3 participants