-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Union type handling #3439
base: 8.3
Are you sure you want to change the base?
Conversation
493078a
to
8df5aa8
Compare
…ion handles union type annotations different
I think ...
|
self::assertEquals( | ||
[ | ||
'returnTypeA' => 'string|false', | ||
'returnTypeB' => '\Neos\Flow\Tests\Functional\Reflection\Fixtures\DummyClassWithUnionTypeHints|false', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PHP FQCN in strings never have a leading backslash – should we handle that the same way? At least consistency would be great, seeing the next test expects those without a leading backslash…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests just took what the type hints created for granted. May aswell be buggy.
self::assertEquals( | ||
[ | ||
'returnTypeA' => 'string|false', | ||
'returnTypeB' => '\Neos\Flow\Tests\Functional\Reflection\Fixtures\DummyClassWithUnionTypeAnnotations|false', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See earlier comment about leading backslash…
Demonstrate broken union types from annotations via test.
Please note tha added case
parameterB1
is equel to parameterB but demonstrates the different handlung of spaces in annotations that lead to detectingmixed
type.see: #3440
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions