Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v2 with main. #129

Merged
merged 89 commits into from
Feb 26, 2024
Merged

Merge v2 with main. #129

merged 89 commits into from
Feb 26, 2024

Conversation

nekitdev
Copy link
Owner

@nekitdev nekitdev commented Jan 9, 2024

This is the tracking PR of the new release of gd.py, aka 2.0.0.

@nekitdev nekitdev added T-feature Type: New feature or request. P-high Priority: High. E-hard Experience: Difficult issue, a lot of experience needed. S-active State: Work in progress. T-fix Type: Fixes an issue. T-change Type: Changes or improvements to existing features. T-layout Type: Layout changes and cleanup. T-internal Type: Internal implementation. A-general Area: General. labels Jan 9, 2024
@nekitdev nekitdev added this to the 2.0.0 milestone Jan 9, 2024
@nekitdev nekitdev requested a review from bswck January 9, 2024 20:17
@bswck bswck marked this pull request as draft January 9, 2024 20:17
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: Patch coverage is 35.42471% with 669 lines in your changes are missing coverage. Please review.

Project coverage is 57.77%. Comparing base (60f5e67) to head (30e1e93).
Report is 1 commits behind head on main.

❗ Current head 30e1e93 differs from pull request most recent head 29d73e9. Consider uploading reports for the commit 29d73e9 to get more accurate results

Files Patch % Lines
gd/api/levels.py 20.28% 110 Missing ⚠️
gd/api/database/database.py 18.18% 99 Missing ⚠️
gd/api/database/variables.py 7.29% 89 Missing ⚠️
gd/api/header.py 27.35% 85 Missing ⚠️
gd/api/color_channels.py 39.21% 62 Missing ⚠️
gd/api/database/storage.py 13.23% 59 Missing ⚠️
gd/api/database/statistics.py 37.50% 45 Missing ⚠️
gd/api/database/unlock_values.py 26.31% 28 Missing ⚠️
gd/artist.py 56.52% 20 Missing ⚠️
gd/api/rewards.py 40.00% 18 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   50.20%   57.77%   +7.56%     
==========================================
  Files         118      112       -6     
  Lines       21504    18005    -3499     
==========================================
- Hits        10797    10403     -394     
+ Misses      10707     7602    -3105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekitdev nekitdev marked this pull request as ready for review February 26, 2024 13:08
@nekitdev nekitdev merged commit 4cb0283 into main Feb 26, 2024
2 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-general Area: General. E-hard Experience: Difficult issue, a lot of experience needed. P-high Priority: High. S-active State: Work in progress. T-change Type: Changes or improvements to existing features. T-feature Type: New feature or request. T-fix Type: Fixes an issue. T-internal Type: Internal implementation. T-layout Type: Layout changes and cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants